Skip to content

Conversation

@naamyuvraj
Copy link

Associated Issue

Low contrast for secondary text in Chat view (light theme).

Description of Changes

This PR improves the light theme contrast for the chat agent metadata row (.agent-session-details-row) in the Chat panel.

Previously, it used --vscode-descriptionForeground, which appears too light on white backgrounds (~3.9:1 contrast ratio), making secondary info hard to read.

Now it uses:

color: var(--vscode-foreground);
opacity: 0.82;

@vs-code-engineering
Copy link

vs-code-engineering bot commented Nov 9, 2025

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css

@bpasero
Copy link
Member

bpasero commented Nov 9, 2025

I would prefer to stay with our semantic colors. Shouldn't the fix apply to the color itself?

export const descriptionForeground = registerColor('descriptionForeground',
{ light: '#717171', dark: transparent(foreground, 0.7), hcDark: transparent(foreground, 0.7), hcLight: transparent(foreground, 0.7) },
nls.localize('descriptionForeground', "Foreground color for description text providing additional information, for example for a label."));

@naamyuvraj naamyuvraj force-pushed the fix/chat-contrast-light-theme branch from 48b7c55 to 923f7cc Compare November 9, 2025 21:03
@naamyuvraj
Copy link
Author

Ok, I have updated descriptionForeground in vscode/src/vs/platform/theme/common/colors/baseColors.ts:

light: '#717171'  '#5C5C5C',
Improved Light+ theme contrast while keeping the semantic color structure intact.

@bpasero bpasero assigned mrleemurray and unassigned bpasero Nov 10, 2025
@naamyuvraj
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants