introduce a whitelist of uids exempted from ip check #60
Conversation
Signed-off-by: Lionel Elie Mamane <[email protected]>
Signed-off-by: Lionel Elie Mamane <[email protected]>
''.split(',') returns [''], not []
Signed-off-by: Lionel Elie Mamane <[email protected]>
|
I had to bump up the nc compatibility version, else the automated test fails with "app is incompatible with this version". I haven't (yet) added test coverage of my extension... Mostly, I haven't understood the testing framework yet. Any help on this is welcome. |
|
It did a first stab at extending the testing code coverage on the "test_code_coverage" branch in my fork: https://github.com/lmamane/limit_login_to_ip/tree/test_code_coverage The issue is I don't know how to simulate a web login in the test. The current test framework just loads the login page without actually trying to login, and tests the result of that. This cannot be useful when there are whitelisted users, because the login page must load successfully, and the login rejected only after we know for which user login is attempted. |
|
@LukasReschke seems a useful contribution, even though I can't really judge the technical side, could you pls? |
Not sure I am still the best to review this @jospoortvliet. But likely it won’t be mergeable anymore. Thanks GitHub for the timely notification.
|
| var UIDs = textData.split(','); | ||
| var UIDs; | ||
| if( textData === '') | ||
| UIDs = [] |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
|
11775909874 |
5 participants
No description provided.