fix: allow occ maintenance:update:htaccess to create .htaccess file in case it doesn't exist yet
#57227
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the updateHtaccess() function can't deal with a missing .htaccess file, it assumes at least an empty .htaccess file. In some cases, the file may be missing though, and this commit adds functionality for creating it when this edgecase occurs. Signed-off-by: Marc <[email protected]>
lpcvoid
requested review from
ArtificialOwl,
come-nc,
nfebe and
provokateurin
and removed request for
a team
This adds a hint to the error message that file creation may also have failed. Signed-off-by: Marc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
updateHtaccess()function can't deal with a missing .htaccess file, it assumes at least an empty .htaccess file.In some cases, the file may be missing though, and this PR adds functionality for creating it when this edgecase occurs.
Before this PR, executing
occ maintenance:update:htaccesscan fail without the error message being explicit about this edgecase.occ maintenance:update:htaccessnot working.Summary
occ maintenance:update:htaccesscan now also create .htaccess files, instead of relying on them being present.TODO
Checklist
3. to review, feature component)stable32)