Skip to content

fix: allow occ maintenance:update:htaccess to create .htaccess file in case it doesn't exist yet #57227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lpcvoid wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Open

fix: allow occ maintenance:update:htaccess to create .htaccess file in case it doesn't exist yet #57227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf1446a
fix: create .htaccess file in case it doesn't exist yet
lpcvoid Dec 22, 2025
90c96d1
fix: changed wording of error for occ maintenance:update:htaccess
lpcvoid Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Command/Maintenance/UpdateHtaccess.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$output->writeln('.htaccess has been updated');
return 0;
} else {
$output->writeln('<error>Error updating .htaccess file, not enough permissions, not enough free space or "overwrite.cli.url" set to an invalid URL?</error>');
$output->writeln('<error>Error updating (or creating) .htaccess file, not enough permissions, not enough free space or "overwrite.cli.url" set to an invalid URL?</error>');
return 1;
}
}
Expand Down
9 changes: 9 additions & 0 deletions lib/private/Setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,15 @@ public static function updateHtaccess(): bool {

$setupHelper = Server::get(\OC\Setup::class);

// Note: The .htaccess file also needs to exist, otherwise `is_writable()`
// will return false, even though the file could be written.
// This function writes the .htaccess file in that case.
if (!file_exists($setupHelper->pathToHtaccess())) {
if (!touch($setupHelper->pathToHtaccess())) {
return false;
}
}

if (!is_writable($setupHelper->pathToHtaccess())) {
return false;
}
Expand Down