Skip to content

fix: harden volume browser path codec#1020

Merged
nicotsx merged 1 commit into
mainfrom
fix/volume-browser-path-codec
Jun 30, 2026
Merged

fix: harden volume browser path codec#1020
nicotsx merged 1 commit into
mainfrom
fix/volume-browser-path-codec

Conversation

@nicotsx

@nicotsx nicotsx commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Volume browser paths are API paths, not native filesystem paths. They
need stable slash-separated encoding so paths containing spaces,
backslashes, or percent-encoded characters can round-trip between the
browser and the agent without escaping the mounted volume root.

This adds a small codec at the volume-host boundary, verifies
symlink/root containment on the resolved native path, and keeps the
local file browser from normalizing user-facing request.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cdaaec8f-97b6-49d6-8fc1-f57ff418a235

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e71a6dbe25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/agent/src/volume-host/operations.ts
Volume browser paths are API paths, not native filesystem paths. They
need stable slash-separated encoding so paths containing spaces,
backslashes, or percent-encoded characters can round-trip between the
browser and the agent without escaping the mounted volume root.

This adds a small codec at the volume-host boundary, verifies
symlink/root containment on the resolved native path, and keeps the
local file browser from normalizing user-facing request.
@nicotsx nicotsx force-pushed the fix/volume-browser-path-codec branch from e71a6db to 45b54e8 Compare June 30, 2026 17:11

nicotsx commented Jun 30, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jun 30, 5:19 PM UTC: A user started a stack merge that includes this pull request via Graphite.

@nicotsx nicotsx merged commit f646bc4 into main Jun 30, 2026
13 checks passed
@nicotsx nicotsx deleted the fix/volume-browser-path-codec branch June 30, 2026 17:21
nicotsx added a commit that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant