Skip to content

Conversation

@mmat11
Copy link
Contributor

@mmat11 mmat11 commented Oct 9, 2025

part of #141

@mmat11 mmat11 requested a review from a team as a code owner October 9, 2025 13:11
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 72.50000% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.97%. Comparing base (885e4c3) to head (71e0a15).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/app/request/span_getters.go 0.00% 18 Missing ⚠️
pkg/ebpf/common/http/graphql.go 75.00% 11 Missing and 4 partials ⚠️
pkg/ebpf/common/http_transform.go 89.02% 7 Missing and 2 partials ⚠️
pkg/app/request/span.go 38.46% 6 Missing and 2 partials ⚠️
pkg/ebpf/common/common.go 73.68% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   71.28%   71.97%   +0.69%     
==========================================
  Files         238      239       +1     
  Lines       25168    25356     +188     
==========================================
+ Hits        17940    18251     +311     
+ Misses       6349     6199     -150     
- Partials      879      906      +27     
Flag Coverage Δ
integration-test 57.64% <63.00%> (-0.41%) ⬇️
integration-test-arm 33.46% <17.50%> (-0.80%) ⬇️
integration-test-vm-${ARCH}-${KERNEL_VERSION} 33.74% <17.50%> (?)
k8s-integration-test 49.27% <16.00%> (-0.63%) ⬇️
oats-test 39.41% <16.00%> (-0.24%) ⬇️
unittests 46.66% <33.50%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I have a question and a suggestion :-)

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations! There are some conflicts that need to be solved (probably because this PR: #754 ) but once we solve them, we are ready to merge.

@mmat11
Copy link
Contributor Author

mmat11 commented Oct 10, 2025

There are some conflicts that need to be solved (probably because this PR: #754 ) but once we solve them, we are ready to merge.

done!

@mariomac mariomac merged commit 9ff3dfa into open-telemetry:main Oct 10, 2025
69 of 81 checks passed
@mmat11 mmat11 deleted the matt/graphql branch October 29, 2025 17:32
@MrAlias MrAlias added this to the v0.1.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants