-
Notifications
You must be signed in to change notification settings - Fork 47
Update and fix OTEL-collector and Tempo in OATS testing #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
grcevski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 55.43% 55.39% -0.04%
==========================================
Files 251 251
Lines 21390 21400 +10
==========================================
- Hits 11857 11855 -2
- Misses 8728 8734 +6
- Partials 805 811 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Automatically updating tempo breaks OATS testing. Trying to manually fix the failing PRs #776 and #808
There were many points of failure so, for simplicity, I've replaced all the moving pieces (collector+metrics+traces) by a single
otel-lgtminstance. This also simplifies configuration.