Repository navigation
feat: add filter distribution sidebar with per-version selection - #333
Bhavishya07-Tech wants to merge 2 commits into
Conversation
|
@TusharB-07 Thanks for your work on this! I think the results sidebar is working, but when I load up these changes in my development environment the list of distributions disappears. Any thoughts?
@vmuralictr Can you take a look at the failing npm test? |
|
hi @pleia2 , Think you meant to tag @Bhavishya07-Tech — not my PR, but the failing npm audit check overlaps with a CI gate I worked on, so I dug into the sidebar bug too. Root cause: Fix: move - {searchPerformed && (
- <div className="results-layout">
- <FilterSidebar ... />
- <div className="results-main">
+ <div className="results-layout">
+ <FilterSidebar ... />
+ {searchPerformed && (
+ <div className="results-main"> |
|
That's what I get for reviewing too many PRs on one afternoon, sorry about that, Tushar! @Bhavishya07-Tech Can you look at my and @TusharB-07's comments above? |
|
Thanks for the feedback, @pleia2 and @TusharB-07! I'm currently looking into this. I'll apply the structural fix to FilterSidebar so it renders on initial page load and resolve the npm audit failure. Will ping you both once the updates are pushed. |
|
@Bhavishya07-Tech Any luck on this? I'm aiming to do some user testing over the next couple weeks, and this sidebar is an important feature for the users who are evaluating the new version of the tool. |
Signed-off-by: Bhavishya Goyal <bhavishya13n@gmail.com> Signed-off-by: vmuralictr <vmurali.ctr@gmail.com>
- Move FilterSidebar outside searchPerformed gate so distro list shows on initial page load (fixes issue reported by @pleia2) - Hide 'Refine results on this page' box until after first search - Fix sidebar position consistency by always rendering results-main and adding width:100% to SearchBar root div - Move HeroSection into results-main to fill space before search - Auto-trigger search when distro version checkboxes change Root cause identified by @TusharB-07, original PR by @Bhavishya07-Tech. Signed-off-by: vmuralictr <vmurali.ctr@gmail.com>
ca5ec07 to
e961fa4
Compare
vmuralictr
left a comment
There was a problem hiding this comment.
Tested locally — all fixes verified:
Distro list shows on page load
Sidebar position is consistent before and after search
"Refine results" box hidden until after first search
Auto-search triggers on checkbox change


Closes #321
Summary
Adds a "Filter distribution" section to the sidebar, allowing users to filter search results by specific point-release versions within a distro family (e.g. Debian 12 vs 11), rather than only by parent distribution.
Changes
FilterSidebarcomponent: collapsible distro groups with per-version checkboxes, plus the "Refine results on this page" search moved here from the results panel (per @pleia2's feedback on the mock-up).SearchBar: replaced flat parent-distro checkbox state with per-version state (selectedVersions), and bit-flag generation now sums selected version flags directly.SearchResults: removed local refine-input state, now receivesrefinePackageNameas a prop from the shared sidebar.Testing
Verified locally with mock distro data — sidebar renders, groups expand/collapse independently, checkbox selection clears "No distribution selected" warning correctly. Full end-to-end search flow needs a live backend to verify against.
@pleia2 ready for review — this follows the mock-up you approved.