Allow users with workspace write permission to edit notebook

[FriedhelmWS]

Description

Issues Resolved

NA

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.23%. Comparing base (45d8e98) to head (cf6b982).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
public/hooks/use_notebook.tsx	50.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   66.20%   66.23%   +0.03%     
==========================================
  Files          59       59              
  Lines        2018     2017       -1     
  Branches      486      490       +4     
==========================================
  Hits         1336     1336              
+ Misses        675      674       -1     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wanglam]

Nit: What about just read currentWorkspace$ here? It should have the same readonly property as well.

[FriedhelmWS]

Done, thanks for the suggestion!

[wanglam]

Maybe an existing issue, do we need to add the owner to the cloned notebook?

[FriedhelmWS]

Fixed

[wanglam]

Hi @FriedhelmWS , do we need to add the readonly check to the start investigation entrypoint? I think it would be fine if it just response a failed to create notebook in the explore page.

[FriedhelmWS]

Hi @FriedhelmWS , do we need to add the readonly check to the start investigation entrypoint? I think it would be fine if it just response a failed to create notebook in the explore page.
We could remove the entry point later tho.