Review and improve legal notice for clarity and accuracy #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying organicmaps with
|
| Latest commit: |
7ae8211
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af2eafcc.organicmaps.pages.dev |
| Branch Preview URL: | https://terms.organicmaps.pages.dev |
biodranik
requested changes
May 31, 2025
Contributor
|
@rtsisyk are you going to incorporate the feedback and update the PR? |
Clarify the information in response to open-source community concerns about the transparency of the legal entity. Full legal details are now available on the Legal page. Signed-off-by: Roman Tsisyk <[email protected]>
Contributor
Author
|
Updated |
biodranik
reviewed
Jul 29, 2025
Comment on lines
+2
to
+3
| See the list of contributors in the CONTRIBUTORS file in the | ||
| organicmaps/organicmaps repository. |
Member
There was a problem hiding this comment.
How is the list of the main app repo contributors related to this repo's contributors?
Comment on lines
+2
to
+3
| See the list of contributors in the CONTRIBUTORS file in the | ||
| organicmaps/organicmaps repository. |
Member
There was a problem hiding this comment.
Suggested change
| See the list of contributors in the CONTRIBUTORS file in the | |
| organicmaps/organicmaps repository. | |
| See the list of this repository's contributors at GitHub: https://github.com/organicmaps/website/graphs/contributors |
| organicmaps/organicmaps repository. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. |
Member
There was a problem hiding this comment.
Looks like this text was written for embedding into each source file, not to be used as a NOTICE.
Suggested change
| you may not use this file except in compliance with the License. | |
| you may not use this code except in compliance with the License. |
| Most libraries in the following directories on [GitHub][github] made by other people and organizations and licensed in different ways: | ||
| ### Website | ||
|
|
||
| Copyright 2020-2025 Organic Maps (OMaps) Contributors; \ |
Member
There was a problem hiding this comment.
Wasn't this website and repo created in 2021?
Suggested change
| Copyright 2020-2025 Organic Maps (OMaps) Contributors; \ | |
| Copyright 2021-2025 Organic Maps (OMaps) Contributors; \ |
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. |
Member
There was a problem hiding this comment.
@vng should notice contain the same wording as in organicmaps/organicmaps#10987 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the information in response to open-source community concerns about the transparency of the legal entity. Full legal details are now available on the Legal page.