fix: allow space managers to remove shares created by other users - #687
Merged
mzner merged 1 commit intoAug 3, 2026
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Space managers with the RemoveGrant permission on a resource were unable to remove user shares created by other users. Unshare in the jsoncs3 share manager only permitted the share creator to remove a share, so removal attempts by other managers failed with a NotFound error, surfaced to callers as a generic HTTP 500. Unshare now also allows users who have the RemoveGrant permission on the shared resource to remove the share, matching the checks already performed in the RemoveShare gRPC handler and GetShare.
mzner
force-pushed
the
fix/OCISDEV-748/space-manager-cannot-remove-shares-created-by-other-users
branch
from
August 3, 2026 06:08
517142d to
40af7fa
Compare
deyankiteworks
approved these changes
Aug 3, 2026
kobergj
approved these changes
Aug 3, 2026
mzner
deleted the
fix/OCISDEV-748/space-manager-cannot-remove-shares-created-by-other-users
branch
August 3, 2026 07:47
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space managers with the RemoveGrant permission on a resource were unable to remove user shares created by other users. Unshare in the jsoncs3 share manager only permitted the share creator to remove a share, so removal attempts by other managers failed with a NotFound error, surfaced to callers as a generic HTTP 500.
Unshare now also allows users who have the RemoveGrant permission on the shared resource to remove the share, matching the checks already performed in the RemoveShare gRPC handler and GetShare.
fixes: https://kiteworks.atlassian.net/browse/OCISDEV-748