Skip to content

Expose default ignored apps in settings#152

Merged
pablopunk merged 1 commit into
mainfrom
fix-ignored-default-apps-ui
May 15, 2026
Merged

Expose default ignored apps in settings#152
pablopunk merged 1 commit into
mainfrom
fix-ignored-default-apps-ui

Conversation

@pablopunk
Copy link
Copy Markdown
Owner

@pablopunk pablopunk commented May 15, 2026

Summary

  • Split always-hidden system ignored apps from user-visible default ignored apps
  • Show default ignored apps like CleanShot/HazeOver in the Ignored Apps tab
  • Allow users to remove/re-add those default ignored apps while keeping system apps always ignored

Fixes #104

Test

  • xcodebuild -project 'Swift Shift.xcodeproj' -scheme 'Swift Shift' -configuration Debug -quiet build

Summary by CodeRabbit

  • Refactor
    • Reorganized the app ignore list to distinguish between system-protected apps and user-ignored apps.
    • System apps (e.g., Notification Center) are now permanently protected and cannot be modified by users.
    • Updated UI messaging to clarify that certain system apps are always ignored.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
swiftshift-app Ready Ready Preview, Comment May 15, 2026 5:50pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8bcd415f-2bf0-4107-9f8f-d83c13716c6f

📥 Commits

Reviewing files that changed from the base of the PR and between d50ed12 and 80bf302.

📒 Files selected for processing (3)
  • Swift Shift/src/Constants.swift
  • Swift Shift/src/Manager/Preferences.swift
  • Swift Shift/src/View/IgnoredAppsTabView.swift

Walkthrough

This PR refactors the app-ignore list to distinguish between system-level ignored bundle IDs (immutable, always hidden) and user-configurable defaults and selections. Constants are split into SYSTEM_IGNORED_APP_BUNDLE_ID and DEFAULT_IGNORED_APP_BUNDLE_ID. PreferencesManager now treats system apps as immutable—preventing add/remove operations on them—while returning defaults only when user preferences are missing. The UI removes its local default-apps tracking and relies entirely on PreferencesManager, eliminating conditional logic that skipped adding apps in the default set.

Possibly related PRs

  • pablopunk/SwiftShift#92: Introduced the PreferencesManager ignored-app persistence and IgnoredAppsTabView UI, which this PR now refactors to separate system and user-configurable ignored apps.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pablopunk pablopunk merged commit 3249fcc into main May 15, 2026
5 of 6 checks passed
@pablopunk pablopunk deleted the fix-ignored-default-apps-ui branch May 15, 2026 17:50
This was referenced May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some windows cannot be moved

1 participant