Skip to content

Expose default ignored apps in settings #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablopunk merged 1 commit into from
May 15, 2026
Merged

Expose default ignored apps in settings #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Swift Shift/src/Constants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
let IGNORE_APP_BUNDLE_ID = [
"com.apple.notificationcenterui",
let SYSTEM_IGNORED_APP_BUNDLE_ID = [
"com.apple.notificationcenterui"
]

let DEFAULT_IGNORED_APP_BUNDLE_ID = [
"pl.maketheweb.cleanshotx",
"pl.maketheweb.cleanshotx-setapp",
"com.pointum.hazeover",
"com.pointum.hazeover-setapp"
]

let IGNORE_APP_BUNDLE_ID = SYSTEM_IGNORED_APP_BUNDLE_ID + DEFAULT_IGNORED_APP_BUNDLE_ID
let MAIN_WINDOW_WIDTH = 320.0
23 changes: 9 additions & 14 deletions Swift Shift/src/Manager/Preferences.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,17 @@ class PreferencesManager {
if let cached = cachedIgnoredApps {
return Array(cached)
}
var apps = Set(IGNORE_APP_BUNDLE_ID)
if let savedApps = UserDefaults.standard.array(forKey: PreferenceKey.ignoredApps.rawValue) as? [String] {
apps.formUnion(savedApps)
}
var apps = Set(SYSTEM_IGNORED_APP_BUNDLE_ID)
apps.formUnion(getUserIgnoredApps())
cachedIgnoredApps = apps
return Array(apps)
}

static func getUserIgnoredApps() -> [String] {
// Return only user-added apps
if let savedApps = UserDefaults.standard.array(forKey: PreferenceKey.ignoredApps.rawValue) as? [String] {
return savedApps
}
return []
return DEFAULT_IGNORED_APP_BUNDLE_ID
}

static func setUserIgnoredApps(_ apps: [String]) {
Expand All @@ -46,22 +43,20 @@ class PreferencesManager {
}

static func addIgnoredApp(_ bundleId: String) {
guard !SYSTEM_IGNORED_APP_BUNDLE_ID.contains(bundleId) else { return }
var currentList = getUserIgnoredApps()

// Don't add apps that are already in default list
if !IGNORE_APP_BUNDLE_ID.contains(bundleId) && !currentList.contains(bundleId) {
if !currentList.contains(bundleId) {
currentList.append(bundleId)
setUserIgnoredApps(currentList)
}
}

static func removeIgnoredApp(_ bundleId: String) {
// Only remove from user list if it's not in the default list
if !IGNORE_APP_BUNDLE_ID.contains(bundleId) {
var currentList = getUserIgnoredApps()
currentList.removeAll { $0 == bundleId }
setUserIgnoredApps(currentList)
}
guard !SYSTEM_IGNORED_APP_BUNDLE_ID.contains(bundleId) else { return }
var currentList = getUserIgnoredApps()
currentList.removeAll { $0 == bundleId }
setUserIgnoredApps(currentList)
}

static func isAppIgnored(_ bundleId: String) -> Bool {
Expand Down
14 changes: 5 additions & 9 deletions Swift Shift/src/View/IgnoredAppsTabView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import UniformTypeIdentifiers

struct IgnoredAppsTabView: View {
@State private var ignoredApps: [String] = []
@State private var defaultIgnoredApps: [String] = []
@State private var appNames: [String: String] = [:]

var body: some View {
Expand Down Expand Up @@ -70,7 +69,7 @@ struct IgnoredAppsTabView: View {
}
}

Text("Some system apps are ignored by default.")
Text("System apps like Notification Center are always ignored.")
.font(.system(size: 10))
.foregroundStyle(.quaternary)
}
Expand All @@ -79,9 +78,8 @@ struct IgnoredAppsTabView: View {
}

private func loadApps() {
defaultIgnoredApps = IGNORE_APP_BUNDLE_ID
ignoredApps = PreferencesManager.getUserIgnoredApps()
for bundleId in (defaultIgnoredApps + ignoredApps) {
for bundleId in ignoredApps {
if let appURL = NSWorkspace.shared.urlForApplication(withBundleIdentifier: bundleId),
let appBundle = Bundle(url: appURL),
let appName = appBundle.object(forInfoDictionaryKey: "CFBundleName") as? String {
Expand All @@ -105,11 +103,9 @@ struct IgnoredAppsTabView: View {
if let bundle = Bundle(url: selectedURL),
let bundleIdentifier = bundle.bundleIdentifier {
let appName = bundle.object(forInfoDictionaryKey: "CFBundleName") as? String ?? bundleIdentifier
if !defaultIgnoredApps.contains(bundleIdentifier) {
PreferencesManager.addIgnoredApp(bundleIdentifier)
appNames[bundleIdentifier] = appName
ignoredApps = PreferencesManager.getUserIgnoredApps()
}
PreferencesManager.addIgnoredApp(bundleIdentifier)
appNames[bundleIdentifier] = appName
ignoredApps = PreferencesManager.getUserIgnoredApps()
}
}
}
Expand Down
Loading