feat(package-vulnerability-scanner): batch package/vuln loading in the content list - #459
Draft
amylin1249 wants to merge 5 commits into
Draft
feat(package-vulnerability-scanner): batch package/vuln loading in the content list#459amylin1249 wants to merge 5 commits into
amylin1249 wants to merge 5 commits into
Conversation
This was referenced Jul 29, 2026
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
July 29, 2026 17:50
596719c to
f2cec20
Compare
Contributor
Extension release summary😴 Changed but won't releaseThe following extensions have code changes but the manifest version hasn't been incremented:
If you intended to release these changes, update the See the contributing guide for details. |
amylin1249
marked this pull request as draft
July 31, 2026 15:43
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 01:30
f2cec20 to
5c03531
Compare
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 01:50
5c03531 to
341debd
Compare
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 03:46
341debd to
bc692cc
Compare
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 04:58
bc692cc to
037c69e
Compare
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 05:46
2986ff1 to
f129666
Compare
…e content list ContentList.vue now fetches packages for the visible content in one batched request (packagesStore.fetchPackages) instead of hand-rolled batches of 3, and no longer clears the package cache on the all-content toggle, so re-viewing already-scanned content makes no new requests. Content that never finished deploying is flagged directly instead of attempting a fetch. Also fixes a sort bug: the "With Vulnerabilities" tab sorted scannerStore.contentWithVulnerabilities in place, mutating the store's cached computed array; now sorts a copy. scanner.ts's currentContent becomes a computed lookup by guid (currentContentGuid) instead of a stored snapshot, so the detail view tracks live package/vulnerability updates instead of what was true at click time. This also lets the store report why a scan failed (scanFailed/scanError), which the content-list empty/error state now uses. ContentCard.vue and VulnerabilityChecker.vue get the one-line update to set currentContentGuid instead of currentContent; their other pending changes are a separate PR.
…wrappers, now unused
…g back to a loaded view After an all-content scan failed, toggling back to your own content left nothing new to fetch, so the store-level failure was never retired: the error banner stayed up, the vulnerability total stayed hidden, and every card read "Not scanned" over data that had loaded fine. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 15:45
f129666 to
99aebcd
Compare
…stale one can't report last Toggling twice quickly let the abandoned view's package read finish after the newer one, leaving its failure on a view whose content had loaded fine. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The packages store's own isLoading was never assigned, and lastFetchTime was written on every fetch but never read, in both the packages and vulns stores. Both predate this work. The per-item isLoading stays: scanner.ts reads it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
amylin1249
force-pushed
the
pvs-07-content-list-ui
branch
from
August 1, 2026 16:38
e747806 to
20b3b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #428 into small, reviewable PRs (tracking issue #415). Stacked 7/10 — stacked on #458, merge bottom-up.
ContentList.vuenow fetches packages for the visible content in one batched request instead of hand-rolled batches of 3, and keeps the package cache across the all-content toggle. Also fixes a sort bug where the "With Vulnerabilities" tab mutated the store's cached array in place, and reworksscanner.tsto track the selected item by guid (live) instead of a stored snapshot.Two toggle bugs the caching introduced, both covered by tests in
ContentList.test.ts:Also drops store state nothing reads: the packages store's own
isLoadingwas never assigned, andlastFetchTimewas written on every fetch but never read, in both the packages and vulns stores. Both predate this work. The per-itemisLoadingstays —scanner.tsreads it.