Skip to content

feat(package-vulnerability-scanner): show the specific reason a scan or read failed - #460

Draft
amylin1249 wants to merge 4 commits into
pvs-07-content-list-uifrom
pvs-08-error-surfacing-ui
Draft

feat(package-vulnerability-scanner): show the specific reason a scan or read failed#460
amylin1249 wants to merge 4 commits into
pvs-07-content-list-uifrom
pvs-08-error-surfacing-ui

Conversation

@amylin1249

@amylin1249 amylin1249 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Split out of #428 into small, reviewable PRs (tracking issue #415). Stacked 8/10 — stacked on #459, merge bottom-up.

VulnerabilityChecker.vue and ContentCard.vue now show the actual failure detail instead of a one-size-fits-all message, with a "Not scanned" badge distinguishing a failed scan from "no vulnerabilities found", plus a loading state for the vulnerability lookup itself so a card doesn't briefly report a false zero.

This is where @karawoo's review comment on #428 lands: the per-item reason from Connect (e.error_message, not the full JSON dump) now reaches the user instead of being swallowed behind fixed text.

@github-actions

Copy link
Copy Markdown
Contributor

Extension release summary

😴 Changed but won't release

The following extensions have code changes but the manifest version hasn't been incremented:

  • package-vulnerability-scanner: manifest version 3.0.6 ≤ released version 3.0.6

If you intended to release these changes, update the version field in each extension's manifest.json.

See the contributing guide for details.

@amylin1249
amylin1249 marked this pull request as draft July 31, 2026 15:43
@amylin1249
amylin1249 force-pushed the pvs-08-error-surfacing-ui branch from 4137c0b to 54f799a Compare August 1, 2026 01:32
@amylin1249
amylin1249 force-pushed the pvs-08-error-surfacing-ui branch from 54f799a to eb71c43 Compare August 1, 2026 01:50
@amylin1249
amylin1249 force-pushed the pvs-08-error-surfacing-ui branch 4 times, most recently from 4dea165 to ddfe2a6 Compare August 1, 2026 05:46
@amylin1249
amylin1249 force-pushed the pvs-08-error-surfacing-ui branch 2 times, most recently from 5ac1c01 to 0db3728 Compare August 1, 2026 16:02
amylin1249 and others added 4 commits August 1, 2026 09:34
…or read failed

VulnerabilityChecker.vue and ContentCard.vue now show the actual detail
(content.packageFetchError.message, scannerStore.scanError) instead of a
one-size-fits-all message, and a "Not scanned" badge distinguishes a failed
scan from "no vulnerabilities found". Adds a loading state for the
vulnerability lookup itself, so a card with loaded packages doesn't briefly
report "no vulnerabilities" before the scan actually finishes.
… inside its own v-else-if

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@amylin1249
amylin1249 force-pushed the pvs-08-error-surfacing-ui branch from 0db3728 to 78e2dcb Compare August 1, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant