nodiscard ChipError Batch #26: platform-specific src: silabs #42089
+120
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces TEMPORARY_RETURN_IGNORED macros across the silabs platform code to handle [[nodiscard]] warnings. While this addresses compiler warnings, it also silences many error conditions that can lead to serious bugs, including silent failure of core functionality, data corruption, resource leaks, and undefined behavior from using uninitialized memory. I've added comments on the most critical instances where ignoring the return value is dangerous and should be addressed. A more systematic approach to error handling is needed rather than temporarily ignoring these return values, especially in functions that are void and have no other way to signal failure.
|
PR #42089: Size comparison from 4859b93 to ea09179 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
andy31415
approved these changes
Nov 24, 2025
andy31415
added
the
sdk-maintainer-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Batch 26 of ignored ChipError for #41629
Related issues
#41629
Testing
CI
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines