Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 5, 2018

Here are a bunch of quick and easy style fixes. We are still a long way from perfection, but this should take care of many of the issues identified by LGTM and most other PEP8 issues aside from variable names.

  • Closes issue #xxxx
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren wholmgren added this to the 0.6.0 milestone Sep 5, 2018
@wholmgren wholmgren mentioned this pull request Sep 6, 2018
8 tasks
@wholmgren wholmgren merged commit f16e53e into pvlib:master Sep 6, 2018
@wholmgren wholmgren deleted the pep8 branch September 6, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants