Skip to content

Update test_psm3.csv to match NSRDB timestamps #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cwhanse wants to merge 46 commits into from
Closed

Update test_psm3.csv to match NSRDB timestamps #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
f475120
initial commit fit_cec_using_sam
cwhanse May 3, 2019
7454e4d
outline ivcurves
cwhanse May 3, 2019
9c5e1a9
use nrel-pysam
cwhanse May 6, 2019
593f355
remove sam_dir
cwhanse May 7, 2019
4ab1fed
add Sandia single curve fit
cwhanse May 7, 2019
8a8890f
complete function
cwhanse May 9, 2019
b72b0b4
add test, move code to ivtools.py
cwhanse May 10, 2019
921aea8
remove single files
cwhanse May 10, 2019
4f4ad0f
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse May 13, 2019
eaee814
change PySCC usage to wrapper
May 14, 2019
d65067b
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
May 14, 2019
4744bde
add nrel-pysam to ci/requirements
May 14, 2019
aae2731
stickler, add pysam version in ci/requirements
May 14, 2019
e1697b0
does case matter?
May 14, 2019
e779c7a
remove pysam for py27, move import pysam to try/except
May 14, 2019
b0f0a9d
add requires_scipy
May 14, 2019
df33113
rename variables for style guide
May 14, 2019
bec1915
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
May 15, 2019
b64cf57
add test for fit_cec_with_sam
May 18, 2019
c8004ff
fix conflict in requirements
May 18, 2019
586a134
fix typo, raise syntax
May 18, 2019
6d6733d
remove ivtools dir
May 18, 2019
98af4ff
fix pytest fixture usage
cwhanse May 18, 2019
26c8f38
linter, fix np.allclose
cwhanse May 18, 2019
1deb148
relax test condition
cwhanse May 18, 2019
3c66a1d
resolve merge conflict
cwhanse May 24, 2019
8308635
remove try/except, add to docstring, use helper functions
cwhanse May 24, 2019
2601dc5
Merge branch 'master' of https://github.com/pvlib/pvlib-python into i…
cwhanse May 27, 2019
632234e
add requires_pysam
cwhanse May 28, 2019
d975f32
fix import
cwhanse May 28, 2019
37a362d
fix infinite loop
cwhanse May 28, 2019
c956486
update whatsnew, api.rst
cwhanse May 28, 2019
bbd5720
fix lint errors
cwhanse May 28, 2019
01f0dba
lint
cwhanse May 28, 2019
a32bb35
resolve comments
cwhanse Jun 12, 2019
5779b1e
comment response
Jun 18, 2019
0f45925
fix function name in test
Jun 18, 2019
58070da
more comment responses
Jun 20, 2019
9bf7566
add nan output to fit_cec_sam, comment responses
cwhanse Jun 21, 2019
723b454
lint
cwhanse Jun 21, 2019
ad9bc2d
consistent return nan, v_oc arg etc. defaults to None, edit description
cwhanse Jun 24, 2019
6d5ff04
initialize failed
cwhanse Jun 24, 2019
d506140
lint
cwhanse Jun 24, 2019
4f3c969
move times by 30 minutes
cwhanse Jun 25, 2019
1753f99
update whatsnew
cwhanse Jun 25, 2019
c9b5e66
Merge branch 'master' of https://github.com/pvlib/pvlib-python into psm3
cwhanse Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/requirements-py35.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ dependencies:
- shapely # pvfactors dependency
- siphon # conda-forge
- pip:
- nrel-pysam
- pvfactors==1.0.1
1 change: 1 addition & 0 deletions ci/requirements-py36.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ dependencies:
- shapely # pvfactors dependency
- siphon # conda-forge
- pip:
- nrel-pysam
- pvfactors==1.0.1
1 change: 1 addition & 0 deletions ci/requirements-py37.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ dependencies:
- shapely # pvfactors dependency
- siphon # conda-forge
- pip:
- nrel-pysam
- pvfactors==1.0.1
8 changes: 8 additions & 0 deletions docs/sphinx/source/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,14 @@ PVsyst model

pvsystem.pvsyst_celltemp

Functions for fitting PV models
-------------------------------
.. autosummary::
:toctree: generated/

ivtools.fit_sde_sandia
ivtools.fit_cec_sam

Other
-----

Expand Down
23 changes: 23 additions & 0 deletions docs/sphinx/source/whatsnew/v0.7.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,31 @@ recommend all users of v0.6.3 upgrade to this release.

**Python 2.7 support ended on June 1, 2019**. (:issue:`501`)

API Changes
~~~~~~~~~~~


Enhancements
~~~~~~~~~~~~
* Add `ivtools` module to contain functions for IV model fitting.
* Add :py:func:`~pvlib.ivtools.fit_sde_sandia`, a simple method to fit the
single diode equation to an IV curve.
* Add :py:func:`~pvlib.ivtools.fit_cec_sam`, a wrapper to access the
model fitting function '6parsolve' from NREL's System Advisor Model.


Bug fixes
~~~~~~~~~


Testing
~~~~~~~
* Shifted times in `test_psm3.csv` by 30 minutes to conform to change in NSRDB timestamps (:issue:`731`)


Contributors
~~~~~~~~~~~~
* Mark Campanellli (:ghuser:`markcampanelli`)
* Will Holmgren (:ghuser:`wholmgren`)
* Cliff Hansen (:ghuser:`cwhanse`)

17,520 changes: 8,760 additions & 8,760 deletions pvlib/data/test_psm3.csv
View file
Open in desktop

Large diffs are not rendered by default.

Loading