Repository navigation
Default radii-only ellipses to zero orientation - #293
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 9, 2026 17:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ellipse advertises theta as optional with a default of None, but Ellipse(radii=(1,2)) passes None into np.cos/np.sin and raises TypeError before constructing the ellipse. Treat omitted or explicit None orientation as zero rotation in the radii constructor. Leave explicit angles and the E-matrix path unchanged, and document the default.
Add 24 cases covering omitted/None/zero/nonzero orientation, integer tuples and floating tuples/arrays for radii, origin/translated centres, the analytic ellipse matrix, containment and area. Original code: 12 omitted/None cases fail, 12 explicit-angle controls pass. Fixed full suite: 590 passed, 3 skipped, 99 subtests passed; 29 existing warnings (untouched baseline: 566 passed with the same skips/subtests/warnings). Python 3.10, NumPy, headless Matplotlib, no hardware. Black 23.10.0, fatal-flake8 selection and git diff --check pass.
This changes only radii-based construction with theta=None. It does not alter polynomial scaling or the open #290 work.
AI assistance was used for investigation, implementation and tests. The validation above was run locally; no robot hardware testing is claimed.