Repository navigation
fix(base): raise ValueError on invalid matrix shape in trinterp - #294
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Signed-off-by: Davis Rens <166565828+davrens101@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trinterpreturns aValueErrorinstance instead of raising it whenendis neither 3x3 nor 4x4, so callers never see the error (the docstring says it raises).trinterp2already usesraise.After the change it raises. Added a test for 2x2 and 5x5 input;
tests/base/test_transforms3d.pypasses.AI assistance: developed with an AI coding assistant; I reproduced the bug and ran the tests locally.