Repository navigation
Apply replacement style options when animating polygons - #296
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 10, 2026 17:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polygon2.animate(T, **kwargs)documents that supplied style options replace the plot options. It saved them toself.args, but constructed the replacement patch fromself.kwargs. For example, plotting red and animating withfacecolor="blue", linewidth=4silently kept the red, thin patch.Store replacement options in the same
self.kwargsfield used by plotting and animation. Calls without new options retain the previous style, including on later frames. Replacement rather than merging follows the documented behavior. Geometry and patch removal are unchanged.Validation: four cases covering identity, translation and rotation with replacement styles, later-frame retention, one-patch cleanup, transformed vertices, and a no-new-options control. Original code: 3 failed / 1 passed. Fixed full suite: 570 passed, 3 skipped, 99 subtests passed; 29 existing warnings. Untouched baseline: 566 passed with the same skips/subtests/warnings. Rendered and visually checked initial red, replacement blue/thick, and subsequent blue/thick frames with Agg. Python 3.10, local CPU/headless rendering, no robot hardware. Black 23.10.0, fatal-flake8 selection on changed files and git diff --check pass; whole-tree fatal-flake8 reports two existing undefined SMPose names in tests/test_dualquaternion.py, untouched here.
AI assistance was used for investigation, implementation and tests.