Repository navigation
Make line-point containment independent of Plucker coordinate scale - #298
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
Refactor line containment check to use normalized direction vector.
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 11, 2026 17:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Line3.contains()comparescross(point - pp, self.w)with an absolute tolerance. Equivalent homogeneous representations of a line therefore give different answers: small direction magnitudes can accept off-line points, and large magnitudes make the distance threshold too strict.Fix
Normalize the direction before taking the cross product in both scalar and batch paths. The residual is then the perpendicular distance, independent of a nonzero Plucker-coordinate scale. Document that tolerance interpretation.
Validation
git diff --checkpass.This changes point containment only, not the line-relation predicates fixed in #232 or line-plane intersection in #291. AI assistance was used for investigation, implementation and tests. Validated locally without robot hardware.