Fix Fit.LAYOUT artboard oversized on Android (experimental)#210
Draft
mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
Draft
Fix Fit.LAYOUT artboard oversized on Android (experimental)#210mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
mfazekas wants to merge 1 commit intofeat/rive-ios-experimentalfrom
Conversation
mfazekas
force-pushed
the
fix/android-fit-layout-scale-factor-experimental
branch
from
e520b6e to
4cb25d3
Compare
Set layoutScaleFactor to device density before setRiveFile when the user hasn't set an explicit value. layoutScaleFactorAutomatic defaults to 1.0 and onMeasure may not fire before the render thread uses it. Fixes #206
mfazekas
force-pushed
the
fix/android-fit-layout-scale-factor-experimental
branch
from
4cb25d3 to
f2e412a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on experimental branch. Same fix as #209.
Set
layoutScaleFactorAutomaticto device density at init time to prevent the render thread from using the default1.0beforeonMeasurefires.Fixes #206