Skip to content

Fix Fit.LAYOUT artboard oversized on Android (experimental) #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mfazekas wants to merge 1 commit into
base: feat/rive-ios-experimental
Choose a base branch
from
Draft

Fix Fit.LAYOUT artboard oversized on Android (experimental) #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions android/src/legacy/java/com/rive/RiveReactNativeView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ class RiveReactNativeView(context: ThemedReactContext) : FrameLayout(context) {
}

fun configure(config: ViewConfiguration, dataBindingChanged: Boolean, reload: Boolean = false, initialUpdate: Boolean = false) {
// https://github.com/rive-app/rive-nitro-react-native/pull/209
riveAnimationView?.layoutScaleFactor = config.layoutScaleFactor
?: resources.displayMetrics.density

if (reload) {
val hasDataBinding = when (config.bindData) {
is BindData.None -> false
Expand All @@ -121,8 +125,6 @@ class RiveReactNativeView(context: ThemedReactContext) : FrameLayout(context) {
} else {
riveAnimationView?.alignment = config.alignment
riveAnimationView?.fit = config.fit
// TODO: this seems to require a reload for the view to take the new value (bug on Android)
riveAnimationView?.layoutScaleFactor = config.layoutScaleFactor
}

if (dataBindingChanged || initialUpdate || reload) {
Expand Down
Loading