Support custom palettes #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A first stab at supporting custom colours
Update sass-export so we don't try to force node-sass 5 which breaks new node.
…ut touching previous isNaN code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I raised this in #17, but the plugin doesn't yet support custom color palettes.
This PR fixes that by breaking the logic for tailwind shades out into a separate if statement and parsing it accordingly.
I've tested this using the default tailwind color shades, plus custom color palettes and both fit into the same logic. We'd likely just need a documentation update to flag that the tailwind.shades option also enables custom palette support.
This PR also bumps sass-export to 2.1 so that it doesn't try to force load node-sass which will can fail to compile on M1 Macs or Mac OS 12 betas as they require newer versions of node which can't compile the deprecated node-sass.