Skip tf2_ros_py test_buffer on Windows to avoid buildfarm aborted bui… #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds (osrf/buildfarmer#360)
mjcarroll
requested changes
Dec 12, 2025
| assert transform.transform.translation.z == output.transform.translation.z | ||
|
|
||
|
|
||
| pytestmark = pytest.mark.skipif( |
Member
There was a problem hiding this comment.
This isn't actually being used anywhere, so it wouldn't have any impact on the build.
|
|
||
|
|
||
| pytestmark = pytest.mark.skipif( | ||
| sys.platform == "win32", |
Member
There was a problem hiding this comment.
I believe this should be 'nt' rather than 'win32'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves CI stability by skipping tf2_ros_py/test_buffer.py on Windows.
According to osrf/buildfarmer#360, several Windows Debug/Release buildfarm jobs abort because of this test.
On Linux (ROS 2 Jazzy) the test passes consistently, so the issue appears to be Windows-specific.
This PR adds a conditional skip:
pytest.mark.skipif(sys.platform == "win32", ...)
allowing the test to continue running on Linux while avoiding CI aborts on Windows.
Validation
Local verification done on Linux (WSL):
colcon test --packages-select tf2_ros_py
colcon test-result --verbose
Result:
202 tests, 0 errors, 0 failures, 51 skipped
Fixes
Fixes osrf/buildfarmer#360
Is this user-facing behavior change?
No — only affects CI test execution on Windows.
Did you use Generative AI?
Yes — ChatGPT was used to assist with debugging instructions and PR wording.
All code changes were written and verified manually.
Additional Information
This PR should reduce aborted Windows jobs on the ROS buildfarm while the root cause of the test flakiness is investigated.