Skip to content

Skip tf2_ros_py test_buffer on Windows to avoid buildfarm aborted bui… #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CoderNived wants to merge 1 commit into
base: jazzy
Choose a base branch
from
Open

Skip tf2_ros_py test_buffer on Windows to avoid buildfarm aborted bui… #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tf2_ros_py/test/test_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.

import sys
import pytest
import rclpy

Expand Down Expand Up @@ -146,3 +147,9 @@ def test_buffer_non_default_cache(self):
assert transform.transform.translation.x == output.transform.translation.x
assert transform.transform.translation.y == output.transform.translation.y
assert transform.transform.translation.z == output.transform.translation.z


pytestmark = pytest.mark.skipif(
Copy link
Member

@mjcarroll mjcarroll Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually being used anywhere, so it wouldn't have any impact on the build.

sys.platform == "win32",
Copy link
Member

@mjcarroll mjcarroll Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be 'nt' rather than 'win32'

reason="Flaky on Windows CI; contributes to aborted builds, see osrf/buildfarmer#360"
)