test_rmw_implementation: add test isolation#275
Merged
fujitatomoya merged 3 commits intoros2:rollingfrom Feb 24, 2026
Merged
Conversation
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
Contributor
Author
|
Pulls: #275
|
fujitatomoya
approved these changes
Feb 24, 2026
Member
|
@Mergifyio backport kilted |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
* test_rmw_implementation: add test isolation Signed-off-by: Julien Enoch <julien.e@zettascale.tech> * add missing test_depend on ament_cmake_ros Signed-off-by: Julien Enoch <julien.e@zettascale.tech> * Fix find_package(ament_cmake_ros) place Signed-off-by: Julien Enoch <julien.e@zettascale.tech> --------- Signed-off-by: Julien Enoch <julien.e@zettascale.tech> (cherry picked from commit 68c340d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation to all tests initializing a Context or a Node, in order to start a Zenoh router in case of rmw_zenoh_cpp.
On my host before this fix:
"zenoh::net::runtime::orchestrator: Scouting delay elapsed before start conditions are met."Total Test time (real) = 131.20 secAfter this fix:
Total Test time (real) = 78.16 secIs this user-facing behavior change?
No
Did you use Generative AI?
No