Fix a -Wreturn-type warning#843
Closed
k0kubun wants to merge 1 commit into
Closed
Conversation
byroot
reviewed
Aug 27, 2025
| case JSON_RAISE: | ||
| return Qfalse; | ||
| default: | ||
| return Qnil; |
Member
There was a problem hiding this comment.
Hum, this should be unreachable. Let me see if I can mark it as such.
Member
Author
There was a problem hiding this comment.
I wasn't sure if C extensions have access to rb_bug or portable assert implementations. That's why I didn't use one, but yeah let's do so if you have an idea.
Member
There was a problem hiding this comment.
I wasn't sure if C extensions have access
They do, but not sure how much of it really is intended to be exposed. So I merged a slightly modified version of your patch: d3f7f04
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Sep 3, 2025
Fix: ruby/json#843 ruby/json@d3f7f0452b Co-Authored-By: Takashi Kokubun <takashikkbn@gmail.com>
hsbt
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 3, 2025
Fix: ruby/json#843 ruby/json@d3f7f0452b Co-Authored-By: Takashi Kokubun <takashikkbn@gmail.com>
byroot
added a commit
to RubyElders/json
that referenced
this pull request
Oct 27, 2025
Fix: ruby#843 Co-Authored-By: Takashi Kokubun <takashikkbn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a warning in ruby/ruby builds: