Skip to content

Fix a -Wreturn-type warning #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
k0kubun wants to merge 1 commit into from
Closed

Fix a -Wreturn-type warning #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/json/ext/generator/generator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1848,6 +1848,8 @@ static VALUE cState_allow_duplicate_key_p(VALUE self)
return Qnil;
case JSON_RAISE:
return Qfalse;
default:
return Qnil;
Copy link
Copy Markdown
Member

@byroot byroot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, this should be unreachable. Let me see if I can mark it as such.

Copy link
Copy Markdown
Member Author

@k0kubun k0kubun Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if C extensions have access to rb_bug or portable assert implementations. That's why I didn't use one, but yeah let's do so if you have an idea.

Copy link
Copy Markdown
Member

@byroot byroot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if C extensions have access

They do, but not sure how much of it really is intended to be exposed. So I merged a slightly modified version of your patch: d3f7f04

}
}

Expand Down
Loading