-
Notifications
You must be signed in to change notification settings - Fork 934
feat: add CI check for HTTPS links in Cargo.toml #8386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CreeptoGengar
wants to merge
11
commits into
sigp:unstable
Choose a base branch
from
CreeptoGengar:feat/ci-check-https-links
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2a2cd7c
Add script to check for HTTP links in Cargo.toml
CreeptoGengar 4f85185
Add HTTPS link check in CI workflow
CreeptoGengar ce67d6e
Update scripts/ci/check-https-links.sh
CreeptoGengar 8bce3b1
Update scripts/ci/check-https-links.sh
CreeptoGengar 3bfec42
Update scripts/ci/check-https-links.sh
CreeptoGengar 5188daa
Update check-https-links.sh
CreeptoGengar 348c0bc
Update Makefile
CreeptoGengar e3133bd
Update test-suite.yml
CreeptoGengar b42903f
Update HTTPS links check to include script permissions
CreeptoGengar efd33d7
Merge branch 'unstable' into feat/ci-check-https-links
CreeptoGengar 3a175bb
Update test-suite.yml
CreeptoGengar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #! /usr/bin/env bash | ||
|
|
||
| # Check for insecure HTTP links in Cargo.toml files | ||
| # This script ensures all git dependencies use HTTPS instead of HTTP | ||
|
|
||
| set -e | ||
|
|
||
| # Find all Cargo.toml files, excluding those in target/ directories | ||
| cargo_toml_files=$(find . -name "Cargo.toml" -type f ! -path "*/target/*") | ||
|
|
||
| # Track if we found any HTTP links | ||
| found_http_links=false | ||
|
|
||
| echo "Checking for HTTP links in Cargo.toml files..." | ||
|
|
||
| # Check each Cargo.toml file | ||
| for file in $cargo_toml_files; do | ||
| # Check for HTTP links (but not HTTPS) | ||
| # We look for patterns like: git = "http://..." or url = "http://..." | ||
| # Using -E for extended regex to handle whitespace variations | ||
| http_links=$(grep -nE '(git|url)\s*=\s*"http://' "$file" 2>/dev/null || true) | ||
|
|
||
| if [ -n "$http_links" ]; then | ||
| echo "ERROR: Found HTTP link(s) in $file:" | ||
| echo "$http_links" | ||
| found_http_links=true | ||
| fi | ||
| done | ||
|
|
||
| if [ "$found_http_links" = true ]; then | ||
| echo "" | ||
| echo "Please replace all HTTP links with HTTPS links in the Cargo.toml files above." | ||
| echo "For example, change: git = \"http://github.com/...\"" | ||
| echo " to: git = \"https://github.com/...\"" | ||
| exit 1 | ||
| else | ||
| echo "✓ All Cargo.toml files use HTTPS links." | ||
| exit 0 | ||
| fi | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has permission issue when I tested locally. This is also caught in the CI: https://github.com/sigp/lighthouse/actions/runs/19207968175/job/55140383694?pr=8386
You need to make the file executable