Skip to content

fix: remove a dangling reference exception handling #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: remove a dangling reference exception handling #357

merged 1 commit into from
Jun 4, 2025

Conversation

@JakubGonera
Copy link
Contributor

@JakubGonera JakubGonera commented Jun 3, 2025 •
edited
Loading

Description

Remove a dangling reference when handling exceptions in forward method in native C++.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@JakubGonera JakubGonera changed the base branch from main to @jakubgonera/cpp-cherry-pick June 3, 2025 14:34
@JakubGonera JakubGonera requested a review from chmjkb June 3, 2025 14:39
msluszniak
msluszniak reviewed Jun 3, 2025
View reviewed changes
Copy link
Member

@msluszniak msluszniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct formatting in line 87 as well.

@JakubGonera JakubGonera merged commit 3535293 into @jakubgonera/cpp-cherry-pick Jun 4, 2025
4 checks passed
@JakubGonera JakubGonera deleted the @jakubgonera/promise-callinvoker branch June 4, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msluszniak msluszniak msluszniak left review comments

@chmjkb chmjkb chmjkb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JakubGonera @msluszniak @chmjkb