Skip to content

fix: remove a dangling reference exception handling #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: remove a dangling reference exception handling #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,19 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
// breaks proper exception type checking. Remove when the
// following change is present in our version:
// https://github.com/facebook/react-native/commit/3132cc88dd46f95898a756456bebeeb6c248f20e
callInvoker->invokeAsync(
[&e, promise]() { promise->reject(e.what()); });
callInvoker->invokeAsync([e = std::move(e), promise]() {
promise->reject(e.what());
});
return;
} catch (const jsi::JSError &e) {
callInvoker->invokeAsync(
[&e, promise]() { promise->reject(e.what()); });
callInvoker->invokeAsync([e = std::move(e), promise]() {
promise->reject(e.what());
});
return;
} catch (const std::exception &e) {
callInvoker->invokeAsync(
[&e, promise]() { promise->reject(e.what()); });
callInvoker->invokeAsync([e = std::move(e), promise]() {
promise->reject(e.what());
});
return;
} catch (...) {
callInvoker->invokeAsync(
Expand Down
Loading