chore(e2e): skip feature-level FixedBy assertions #2491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature-level FixedBy field changes every time a new advisory is published for a package. This causes frequent E2E test failures that require manual updates to the test assertions. Analysis of git history shows that ~74% of commits to testcase_test.go are updates to FixedBy values - maintenance overhead with minimal test value since: 1. Per-vulnerability FixedBy is still validated (stable, per-RHSA) 2. Vulnerability detection (correct CVEs/RHSAs) is still tested 3. CVSS metadata (scores, vectors) is still tested 4. Feature identification (name, version, namespace) is still tested This change mirrors the approach already used in grpc_test.go which clears FixedBy before comparison.
BradLugo
approved these changes
Dec 9, 2025
Contributor
BradLugo
left a comment
BradLugo
left a comment
There was a problem hiding this comment.
LGTM. Is the plan to backport these changes to the release branches?
Contributor
Author
|
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
Analysis of git history shows that ~74% of commits to
testcase_test.goare updates to FixedBy values. This represents significant maintenance overhead with minimal test value since the feature-level FixedBy simply aggregates the max fix version across all vulnerabilities.What is still tested:
This change mirrors the approach already used in
grpc_test.go(line 53) which clears FixedBy before comparison.Test plan