chore(prisma): isolate client into per-package output dir (monorepo prep)

[oakinh]

Monorepo prep

Behavior-preserving upstream normalization ahead of the omni monorepo migration. The monorepo sync is additive/deterministic, so we fix upstream here first where CI validates in the real environment.

What

• prisma/schema/schema.prisma: add output = "../../src/generated/prisma" to the generator client block (existing provider/binaryTargets/previewFeatures unchanged) so each package owns an isolated generated Prisma client.
• .gitignore: ignore src/generated/.
• Rewrote the bare @prisma/client import specifier to the relative generated path across 20 sites / 20 files (validated codemod). @prisma/client/... subpath imports are intentionally left alone — they still resolve to the real npm package the generated client depends on.

Validation

• npx prisma generate → confirmed output to src/generated/prisma.
• npm run build ✅ (zero Prisma-resolution errors).
• npm test → 116 passed, 1 skipped; the only failing suite is a DB integration test (election_api_test does not exist on localhost) — environment-only, unrelated to this change. Notably it resolves the new client from src/generated/prisma/runtime/library.js, confirming runtime resolution works.
• src/generated/ confirmed git-ignored; not committed.

Made with Cursor

---

Note

Medium Risk
Changes how the Prisma client is built and shipped (CI, Docker, and all DB type imports); a missed prisma generate or wrong Docker copy would break builds or production DB access, though runtime behavior is intended to stay the same.

Overview
Moves the Prisma client from the default @prisma/client package into a gitignored per-package output at src/generated/prisma, ahead of monorepo work so each package can own its own generated client.

Schema & imports: generator client now sets output = "../../src/generated/prisma". Application code that imported Prisma, PrismaClient, and model enums from @prisma/client now uses relative paths like ../generated/prisma (many modules under src/).

Tooling: .gitignore ignores src/generated/. PR CI runs npx prisma generate after npm ci and before tsc / tests so type-checking sees the generated client. Docker stops copying node_modules/.prisma and instead copies the built src/generated/prisma tree into dist/src/generated/prisma so compiled Nest code can load the client and query engine at runtime.

^{Reviewed by Cursor Bugbot for commit a5ba99c. Configure here.}

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[delegate-reviewer]

1 blocker. Reply delegate review after fixing.

Inline comments could not be posted (file not in diff). Findings below.

.github/workflows/main.yml:42-43 — deploy pipeline missing prisma generate before tests

The deploy pipeline runs npm run test immediately after npm ci with no prisma generate step. The Prisma client is output to src/generated/prisma (per prisma/schema/schema.prisma line 5), which is listed in .gitignore line 6. Twenty-three source files — including test files — import from that generated path. Without generation, every test run in the deploy pipeline will fail at module resolution.

pull-request.yml already has the correct fix (line 23: npx prisma generate); the same step is simply missing here.

      - run: npm ci
      - run: npx prisma generate
      - run: npm run test

[oakinh]

Both blockers + the Bugbot finding addressed in a5ba99c:

1. Runtime image missing the generated client / query engine — nest build doesn't emit src/generated/prisma into dist, and node_modules/.prisma is no longer produced in custom-output mode (so the old COPY node_modules/.prisma would itself fail). The generated client is fully self-contained (client JS + bundled runtime/ + libquery_engine-linux-musl.so.node). I now copy it to the exact path the compiled code resolves at runtime: COPY --from=builder /app/src/generated/prisma ./dist/src/generated/prisma. Verified locally: node -r ./dist/src/otel.js dist/src/main.js boots, loads the engine from dist/src/generated/prisma/runtime/library.js, and only fails on DB auth (env-only) — i.e., no module-resolution/engine error.

2. CI missing prisma generate — added an explicit npx prisma generate step before tsc --noEmit/tests. (Note: the PR-validation job was already green because @prisma/client's postinstall auto-generates during npm ci; the explicit step removes reliance on that implicit side effect.)

delegate review

[oakinh]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a5ba99c. Configure here.}

[oakinh]

Addressed in 8d39bf6: added the same explicit npx prisma generate step to main.yml (deploy pipeline) before npm run test, mirroring the fix already in pull-request.yml. Both pipelines now generate the client into src/generated/prisma before type-check/tests rather than relying on @prisma/client's implicit postinstall.

delegate review

[delegate-reviewer]

Approved.