MdeModulePkg/BrotliCustomDecompressLib: Correct BrotliDecompress #11729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Presumably this bug was hidden from other toolchains by the otherwise pointless initialization to 0 on line 279. However, |
mikebeaton
added a commit
to mikebeaton/edk2
that referenced
this pull request
Nov 8, 2025
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter and mark the method STATIC. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
force-pushed
the
mdemodulepkg-bug
branch
from
6e0ac44 to
6d02f26
Compare
mikebeaton
added a commit
to mikebeaton/edk2
that referenced
this pull request
Nov 8, 2025
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter, also marking the method STATIC and renaming it to ...Internal. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
force-pushed
the
mdemodulepkg-bug
branch
from
6d02f26 to
43fde94
Compare
Contributor
Author
|
@leiflindholm - Looking at the code, IMO the intention may have been to provide something which could be called elsewhere. However it is not declared in any header file and never is called elsewhere. So I've updated the PR to remove the broken parameter completely, and marked the method STATIC and renamed it as ...Internal. |
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter, also marking the method STATIC and renaming it to ...Internal. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
force-pushed
the
mdemodulepkg-bug
branch
from
43fde94 to
5e2a1e2
Compare
leiflindholm
approved these changes
Nov 8, 2025
mikebeaton
added a commit
to mikebeaton/edk2
that referenced
this pull request
Nov 8, 2025
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter, also marking the method STATIC and renaming it to ...Internal. Signed-off-by: Mike Beaton <[email protected]>
mikebeaton
added a commit
to mikebeaton/edk2
that referenced
this pull request
Nov 9, 2025
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter, also marking the method STATIC and renaming it to ...Internal. Signed-off-by: Mike Beaton <[email protected]>
3 tasks
mikebeaton
added a commit
to acidanthera/audk
that referenced
this pull request
Nov 16, 2025
DestSize should have been received and passed as a pointer in order to successfully pass the output value. The existence of this error was spotted by XCODE5 toolchain, which gave: BrotliDecompress.c:85:18: error: parameter 'DestSize' set but not used As discussed in tianocore/edk2#11729, since the method is in fact internal and only called in one place, and since the DestSize return value is in fact unused, instead of fixing the parameter and method call we instead remove the parameter, also marking the method STATIC and renaming it to ...Internal. Signed-off-by: Mike Beaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a relatively minor but genuine code bug identified by XCODE5 build.
How This Was Tested
Confirm valid XCODE5 build after changes. Confirm no break in EDK 2 CI.
Integration Instructions
N/A