Skip to content

Conversation

@vbpandya
Copy link
Contributor

@vbpandya vbpandya commented Nov 11, 2025

In "if (RpInfo[Index].Sun != MAX_UINT64)", "RpInfo[Index].Sun" is UINT32 type.
Which means it is never going to be equal to MAX_UINT64, so use "RpInfo[Index].Sun != MAX_UINT32" instead.

Description

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

This issue causes an error while building with clang, with this commit there is no error.

Integration Instructions

N/A

@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>

Address these issues and the validation will automatically re-run when you update your pull request.

@pierregondois
Copy link
Contributor

Hello Varshit,
The changes seems correct, but would it be possible to remove the 'Merge' commit ?
I.e. just rebasing on the latest master

In "if (RpInfo[Index].Sun != MAX_UINT64)", "RpInfo[Index].Sun" is UINT32 type.
Which means it is never going to be equal to MAX_UINT64, so use
"RpInfo[Index].Sun != MAX_UINT32" instead.

Signed-off-by: Varshit Pandya <[email protected]>
@vbpandya vbpandya force-pushed the fix_redundant_condition_in_DynamicTablesPkg branch from adb5480 to 68dcdd3 Compare November 17, 2025 10:06
@vbpandya
Copy link
Contributor Author

Hello Varshit, The changes seems correct, but would it be possible to remove the 'Merge' commit ? I.e. just rebasing on the latest master

Apologies, didn't mean to do that, I guess I don't understand the rebase from GUI yet :D

Copy link
Contributor

@pierregondois pierregondois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Just need to wait next week for the end of the feature freeze:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants