Skip to content

Conversation

@HansRobo
Copy link
Member

The previous noise mechanism is not in use

This required accessing Publisher::randomize to obtain normal distribution error standard deviations

Signed-off-by: Mateusz Palczuk [email protected]# Description

Please check examples and comment out this sentence. Minimal example is here and detailed example is here

Abstract

[Required] This section is required, keep it short, clear and to the point.
Delete this sentence and explain this pull request shortly.

Background

[Optional] If there is no background information that needs explanation (e.g., just a typo correction, etc.), you can skip this section.
Delete this sentence and explain the circumstances that led to this pull request being sent.

Details

[Optional] If there are only differences whose effects are so obvious that no explanation is needed, or if there are no differences in the code (e.g., documentation additions), you can skip this section.
Delete this sentence and describe this pull request.
For example, it is desirable to describe the specifications of added functions, and detailed explanations of bugs that have been fixed.

References

[Optional] If the referenced material does not exist, you can skip this section.
Describe any standards, algorithms, books, articles, etc. that you referenced when creating the pull request. If there is any novelty, mention it.

Destructive Changes

[Optional] If no destructive change exists, you can skip this section.
Include a description of the changes and a migration guide and send the pull request with a bump major label. (Example : #1139)
Otherwise, skip the "Destructive Changes" section and make sure this pull request is labeled bump minor or bump patch.

Known Limitations

[Optional] If there are no known limitations that you can think of, you can skip this section. If there are any limitations on the features or fixes added by this pull request, delete this sentence and clearly describe them.
For example, the lane matching algorithm currently (1/25/2024) employed is unable to match Entity that is heavily tilted with respect to the lane, and it is difficult to throw an exception.
If the developer is aware of the existence of such problems or limitations, describe them in detail. The problems or limitation should be listed as an Issue on GitHub and a link to it should be provided in this section.

TauTheLepton and others added 20 commits November 18, 2025 22:07
The previous noise mechanism is not in use

This required accessing Publisher::randomize to obtain normal distribution error standard deviations

Signed-off-by: Mateusz Palczuk <[email protected]>
Test applying noise using legacy parameters - simulation_api_schema

Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
…use the same convention

Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Skip the randomization process altogether instead of disabling all errors and performing other operations that achieve nothing

Signed-off-by: Mateusz Palczuk <[email protected]>
… non-mutable

Adjust ImuSensor + ImuSensorBase update member functions to non-const - similar to other sensors

Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Ensure variances (diagonal) are not 0.0, or otherwise Autoware localization gets confused (only when simulate_localization:=false)

Signed-off-by: Mateusz Palczuk <[email protected]>
This reverts commit c729976.

Signed-off-by: Mateusz Palczuk <[email protected]>
…in legacy configuration

This was done so that covariance matrices are calculated to be non-zero (their diagonal). Otherwise the Autoware gets confused and Ego starts shaking in RViz.

Signed-off-by: Mateusz Palczuk <[email protected]>
@github-actions
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@sonarqubecloud
Copy link

Base automatically changed from feature/publisher-noise-pose to master November 20, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants