Add IsProductionSafe to Blockstore metadata #9822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
github-actions
bot
added
area/testing
N-o-Z
approved these changes
Dec 16, 2025
Member
N-o-Z
left a comment
N-o-Z
left a comment
There was a problem hiding this comment.
Not very excited about this approach - this could have been resolved with a simple hardcoded list of production ready adapters.
But this works so I'm not blocking.
Please see one comment
pkg/block/transient/adapter.go
Outdated
| func (a *Adapter) BlockstoreMetadata(_ context.Context) (*block.BlockstoreMetadata, error) { | ||
| return nil, block.ErrOperationNotSupported | ||
| return &block.BlockstoreMetadata{ | ||
| IsProductionSafe: true, |
Contributor
Author
There was a problem hiding this comment.
Here's a bug that this fix has already discovered :)
github-actions
bot
added
the
area/auth
|
Einat Aloni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8681.
This PR is used for Enterprise.
Change Description
Making production warning for blockstores part of the Blockstore Adapter metadata.
Testing Details
Tested the warning locally (appears for "mem", doesn't for other types).
Also, unit and integration tests in the blockstore area provide a pretty decent coverage.