Chain WordPress.org deploy into publish-release.yml - #843
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| deploy-wporg: | ||
| if: ${{ inputs.deploy_wporg && !inputs.prerelease }} | ||
| needs: release | ||
| uses: udx/reusable-workflows/.github/workflows/wp-org-svn-deploy.yml@master |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| needs: release | ||
| uses: udx/reusable-workflows/.github/workflows/wp-org-svn-deploy.yml@master | ||
| with: | ||
| tag: ${{ github.event.inputs.tag }} |
There was a problem hiding this comment.
🔴 Distinct release tags misname packages
When tag differs from the plugin version, deploy-wporg names the WordPress.org package after the GitHub tag. The stable version then has no matching SVN package.
Prompt for agents
The publish workflow supports separate tag and version inputs, but wp-org-svn-deploy.yml accepts only tag and passes it to the 10up deploy action as VERSION. Extend the reusable workflow to accept the WordPress plugin version separately from the Git checkout tag, then pass the caller's version input to it. Preserve the existing release workflow's fallback behavior when version is omitted, such as deriving the stable version from readme.txt, so tags like 1.2.3a or v1.2.3 can still deploy the correct WordPress.org tags/<version> directory.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🟢 Approval recommended
The workflow correctly gates deployment and matches the reusable workflow contract, pending merge of udx/reusable-workflows#60.
Pull request overview
Chains WordPress.org deployment to the existing GitHub release workflow.
Changes:
- Adds an optional WordPress.org deployment input.
- Deploys successful stable releases using the reusable workflow.
- Passes scoped SVN credentials securely.
File summaries
| File | Description |
|---|---|
.github/workflows/publish-release.yml |
Adds conditional WordPress.org deployment after release. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
deploy-wporgjob topublish-release.ymlthat runs after a successful GitHub release and deploys the tag to the WordPress.org Plugin Directory via the new reusable workflow (udx/reusable-workflows#60).deploy_wporgdispatch input is uncheckedSVN_USERNAME/SVN_PASSWORD(scoped: this repo only), referenced viasecrets.*— no credentials in the repoSafe to merge after udx/reusable-workflows#60 (until then the job would fail fast on a missing workflow).