Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
prerelease:
description: 'Pre-release version (e.g. RC1, beta, etc...)'
required: false
deploy_wporg:
description: 'Deploy to WordPress.org after release (skipped for pre-releases)'
required: false
default: true
type: boolean

permissions:
contents: write
Expand All @@ -24,3 +29,13 @@
tag: ${{ github.event.inputs.tag }}
version: ${{ github.event.inputs.version }}
prerelease: ${{ github.event.inputs.prerelease }}

deploy-wporg:
if: ${{ inputs.deploy_wporg && !inputs.prerelease }}
needs: release
uses: udx/reusable-workflows/.github/workflows/wp-org-svn-deploy.yml@master
with:
tag: ${{ github.event.inputs.tag }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Distinct release tags misname packages

When tag differs from the plugin version, deploy-wporg names the WordPress.org package after the GitHub tag. The stable version then has no matching SVN package.

Prompt for agents
The publish workflow supports separate tag and version inputs, but wp-org-svn-deploy.yml accepts only tag and passes it to the 10up deploy action as VERSION. Extend the reusable workflow to accept the WordPress plugin version separately from the Git checkout tag, then pass the caller's version input to it. Preserve the existing release workflow's fallback behavior when version is omitted, such as deriving the stable version from readme.txt, so tags like 1.2.3a or v1.2.3 can still deploy the correct WordPress.org tags/<version> directory.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

secrets:
svn_username: ${{ secrets.SVN_USERNAME }}
svn_password: ${{ secrets.SVN_PASSWORD }}
Loading