fix: vgpu memory allocate wrong when use volcano.sh/vgpu-memory-percentage

[shoted]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
when use volcano.sh/vgpu-memory-percentage, vgpu-memory always is 0

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jessestutler
You can assign the PR to them by writing /assign @jessestutler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @shoted, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the vGPU memory allocation mechanism. Previously, when users specified vGPU memory as a percentage using the volcano.sh/vgpu-memory-percentage annotation, the system would incorrectly calculate the allocated memory as zero due to an integer division order issue. The change rectifies this calculation, ensuring that vGPU memory is now correctly determined and assigned based on the provided percentage, thereby preventing resource under-allocation.

Highlights

• Bug Fix: Resolved an issue where vGPU memory was incorrectly allocated as zero when using the volcano.sh/vgpu-memory-percentage annotation.
• Calculation Correction: Fixed an integer division error in the vGPU memory calculation logic, ensuring that the percentage-based memory request is accurately computed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug where GPU memory requests specified as a percentage were incorrectly calculated as zero due to integer division. The fix correctly reorders the multiplication and division operations, ensuring proper memory allocation. The change is correct and effectively resolves the issue. I've added a suggestion to include a regression test to prevent this issue from recurring.

[gemini-code-assist]

The fix for the integer division is correct. To prevent this bug from recurring, it's important to add a regression test. Please consider adding a unit test for checkNodeGPUSharingPredicateAndScore that verifies the correct memory calculation when a pod requests GPU resources using the volcano.sh/vgpu-memory-percentage annotation.

[volcano-sh-bot]

@shoted: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.