Skip to content

fix: vgpu memory allocate wrong when use volcano.sh/vgpu-memory-percentage #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: vgpu memory allocate wrong when use volcano.sh/vgpu-memory-percentage #4698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scheduler/api/devices/nvidia/vgpu/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ func checkNodeGPUSharingPredicateAndScore(pod *v1.Pod, gssnap *GPUDevices, repli
continue
}
if val.MemPercentagereq != 101 && val.Memreq == 0 {
val.Memreq = gs.Device[i].Memory * uint(val.MemPercentagereq/100)
val.Memreq = gs.Device[i].Memory * uint(val.MemPercentagereq) / 100
Copy link

@gemini-code-assist gemini-code-assist bot Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fix for the integer division is correct. To prevent this bug from recurring, it's important to add a regression test. Please consider adding a unit test for checkNodeGPUSharingPredicateAndScore that verifies the correct memory calculation when a pod requests GPU resources using the volcano.sh/vgpu-memory-percentage annotation.

}
if int(gs.Device[i].Memory)-int(gs.Device[i].UsedMem) < int(val.Memreq) {
continue
Expand Down
Loading