Fix for glitch preventing subelements of indexed array to map correctly. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switzer
pushed a commit
to switzer/node-object-mapper
that referenced
this pull request
Oct 9, 2019
switzer
reviewed
Oct 12, 2019
switzer
left a comment
switzer
left a comment
There was a problem hiding this comment.
The code base has changed significantly since these changes were made. I took the tests that you wrote for this pull request and added them to my branch. The tests pass.
switzer
pushed a commit
to switzer/node-object-mapper
that referenced
this pull request
Oct 12, 2019
…x is being modified. further cleanup is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue with the mapping framework I found while working on a personal project.