Skip to content

Fix for glitch preventing subelements of indexed array to map correctly. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for glitch preventing subelements of indexed array to map correctly. #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f04ef7
Fix for glitch preventing subelements of indexed array to map correctly.
Oct 25, 2018
0998699
Fix to be compliant with the strict mode.
Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/set-key-value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,43 @@ function _setValue(destinationObject, key, keys, fromValue) {
if (Array.isArray(fromValue) && _isNextArrayProperty(keys) === false) {
for (valueIndex = 0; valueIndex < fromValue.length; valueIndex++) {
value = fromValue[valueIndex];
destinationObject[key][arrayIndex + valueIndex] = _setValue(destinationObject[key][arrayIndex + valueIndex], keys[0], keys.slice(1), value);
var targetIndex = arrayIndex ? parseInt(arrayIndex) : parseInt(valueIndex);
destinationObject[key][targetIndex] = _setValue(destinationObject[key][targetIndex], keys[0], keys.slice(1), value);
}
} else {
destinationObject[key][arrayIndex] = _setValue(destinationObject[key][arrayIndex], keys[0], keys.slice(1), fromValue);
var findFirstIndexWithoutProp = function(keys, array) {
for(var i=0;i<array.length;i++) {
if(!subElementExists(keys, array[i])) {
return i;
}
}

return array.length;
};

var subElementExists = function(keys, objectToCheck) {
var keyToCheck = keys[0];
var otherKeys = keys.slice(1);

if (objectToCheck[keyToCheck] && otherKeys.length == 0 ) {
return true;
} else if (objectToCheck[keyToCheck]) {
return subElementExists(otherKeys, objectToCheck[keyToCheck]);
}

return false;
};

var targetIndex = destinationObject[key][arrayIndex] && subElementExists(keys, destinationObject[key][arrayIndex]) ? findFirstIndexWithoutProp(keys, destinationObject[key]) : arrayIndex;
destinationObject[key][targetIndex] = _setValue(destinationObject[key][targetIndex], keys[0], keys.slice(1), fromValue);
}
} else if (Array.isArray(destinationObject)) {
if (Array.isArray(fromValue)) {
for (valueIndex = 0; valueIndex < fromValue.length; valueIndex++) {
value = fromValue[valueIndex];
destinationObject[arrayIndex + valueIndex] = _setValue(destinationObject[arrayIndex + valueIndex], keys[0], keys.slice(1), value);
var arrayIndexInt = parseInt(arrayIndex);
var valueIndexInt = parseInt(valueIndex);
destinationObject[arrayIndexInt + valueIndexInt] = _setValue(destinationObject[arrayIndexInt + valueIndexInt], keys[0], keys.slice(1), value);
}
} else {
destinationObject[arrayIndex] = _setValue(destinationObject[arrayIndex], keys[0], keys.slice(1), fromValue);
Expand Down
220 changes: 220 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,3 +1885,223 @@ test('Mapping properties with glob patterns with incomplete path', function (t)
t.deepEqual(result, expect);
t.end();
});

test('Should correctly map to a subelement of indexed array item.', function (t) {
var obj = {
"nodes": [
{
"type": "db",
"image": "mongodb"
},
{
"type": "app",
"image": "nginx"
}
]
};

var expect = {
"result": [ {
"env": {
"nodes": [
{
"type": "db",
"image": "mongodb"
},
{
"type": "app",
"image": "nginx"
}]
}
}]
};
var map = {
'nodes[].type': 'result[0].env.nodes[].type',
'nodes[].image': 'result[0].env.nodes[].image'
};

var result = om(obj, map);

t.deepEqual(result, expect);
t.end();
});

test('Should correctly map to a subelement of indexed array item deep in the object hierarchy.', function (t) {

var obj = {
policyNumber: "PN1",
status: "ST1",
productName: "PN1",
productVersion: "PV1",
productType: "PT1",
startDate: "SD1",
endDate: "ED1",
policyContacts: [
{
contactType: "CT11",
contactId: "CI11"
},
{
contactType: "CT12",
contactId: "CI12"
}
],
currency: "CUR1",
covers: [
{
coverName: "CN11",
coverId: "CID11",
startDate: "SD11",
endDate: "ED11",
excess: "EX11",
insuredAmount: "IA11",
yearlyPremium: "YP11",
status: "ST11"
}
],
riskObjects: [
{
assetId: "AID11",
type: "T11",
assetDescription: "AD11",
address: {
city: "C11",
houseNumber: "HN11",
country: "CN11",
zipCode: "ZC11",
}
}
]

};

var expect = {
policyHeader: [
{
policiesList: {
policies: {
externalPolicyNr: "PN1",
policyLobsList: {
policyLobs: {
lobRef: {
value: "PT1"
},
policyLobAssetsList: {
policyLobAssets: [
{
coversList: {
covers: [
{
coverPerilsList: {
coverPerils: [
{
perilRef: {
value: "CN11"
}
}
]
},
externalNumber: "CID11",
startDate: "SD11",
endDate: "ED11",
excessAmount: "EX11",
insuranceAmount: "IA11",
basicYearlyPremiumAmount: "YP11",
coverStatusRef: {
value: "ST11"
}
}
]
},
originalLobAssetId: "AID11",
asset: {
assetTypeRef: {
value: "T11"
},
propertyOccupationTypeRef: "AD11",
address: {
cityName: "C11",
houseNr: "HN11",
countryRef: {
value: "CN11"
},
zipCode: "ZC11"

}

}
}
]

}
}
},
policyContactsList: {
policyContacts: [
{
policyContactRoleRef: {
value: "CT11"
},
contactExtNum: "CI11"
},
{
policyContactRoleRef: {
value: "CT12"
},
contactExtNum: "CI12"
},
]
}
}
},
statusCodeRef: {
value: "ST1"
},
productRef: {
value: "PN1"
},
productVersionRef: {
value: "PV1"
},
policyStartDate: "SD1",
policyEndDate: "ED1",
currencyRef: {
value: "CUR1"
}
}
]
};

var map = {
"covers[].coverId": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].externalNumber",
"covers[].coverName": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].coverPerilsList.coverPerils[0].perilRef.value",
"covers[].endDate": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].endDate",
"covers[].excess": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].excessAmount",
"covers[].insuredAmount": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].insuranceAmount",
"covers[].startDate": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].startDate",
"covers[].status": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].coverStatusRef.value",
"covers[].yearlyPremium": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].coversList.covers[].basicYearlyPremiumAmount",
"currency": "policyHeader[0].currencyRef.value",
"endDate": "policyHeader[0].policyEndDate",
"policyContacts[].contactId": "policyHeader[0].policiesList.policies.policyContactsList.policyContacts[].contactExtNum",
"policyContacts[].contactType": "policyHeader[0].policiesList.policies.policyContactsList.policyContacts[].policyContactRoleRef.value",
"policyNumber": "policyHeader[0].policiesList.policies.externalPolicyNr",
"productName": "policyHeader[0].productRef.value",
"productType": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.lobRef.value",
"productVersion": "policyHeader[0].productVersionRef.value",
"riskObjects[].address.city": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.address.cityName",
"riskObjects[].address.country": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.address.countryRef.value",
"riskObjects[].address.houseNumber": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.address.houseNr",
"riskObjects[].address.zipCode": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.address.zipCode",
"riskObjects[].assetDescription": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.propertyOccupationTypeRef",
"riskObjects[].assetId": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].originalLobAssetId",
"riskObjects[].type": "policyHeader[0].policiesList.policies.policyLobsList.policyLobs.policyLobAssetsList.policyLobAssets[].asset.assetTypeRef.value",
"startDate": "policyHeader[0].policyStartDate",
"status": "policyHeader[0].statusCodeRef.value"
};

var result = om(obj, map);

t.deepEqual(result, expect);
t.end();
});