[3/5] Hydrate remote project skills#11862
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Overview
This PR extends project skill watching to hydrate remote skill files through the remote server read-file context API, parse them as project skills, and handle remote skill deletion paths. It also adds unit coverage for remote parsing, provider classification, read request limits, and remote deletion events.
Concerns
- The remote refresh branch currently moves
repo_idand then tries to clone it again, which will fail to compile. - This is user-facing behavior because remote project skills become available to agents, but the PR description has no testing notes or screenshots/recording demonstrating the remote hydration path end to end. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 1 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| local_skill_files, | ||
| ctx, | ||
| ); | ||
| if let RepositoryIdentifier::Remote(remote_repo) = repo_id { |
There was a problem hiding this comment.
🚨 [CRITICAL] This match moves repo_id into remote_repo, then the body calls repo_id.clone() and later uses repo_id again, so this branch will not compile. Borrow the enum in the pattern instead.
| if let RepositoryIdentifier::Remote(remote_repo) = repo_id { | |
| if let RepositoryIdentifier::Remote(remote_repo) = &repo_id { |
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
f26e6a6 to
8f90600
Compare
436ae71 to
1b2b511
Compare

Description
PR 3/5 of the remote-aware skills stack.
Hydrate project skills from remote working directories and classify provider locations structurally, without temporarily coercing remote locations into local paths for shared logic.
Plan: https://staging.warp.dev/drive/notebook/EAngN0Hb9BqY5WiPMTXFV5
Agent run: https://staging.warp.dev/conversation/88702634-8ffe-46a4-b868-1efae92630eb
Linked Issue
ready-to-specorready-to-implement.Testing
cargo fmt --manifest-path Cargo.toml -p warp_util -p ai -p warpcargo test -p ai skill_provider --libcargo test -p warp parse_remote_skill_file_contexts --libFull workspace clippy was started on the cumulative stack tip but not completed before submission.
I have manually tested my changes locally with
./script/runAgent Mode
Co-Authored-By: Oz oz-agent@warp.dev