Skip to content

[3/5] Hydrate remote project skills#11862

Merged
moirahuang merged 5 commits into
moira/skills-api-referencesfrom
moira/skills-hydration
May 29, 2026
Merged

[3/5] Hydrate remote project skills#11862
moirahuang merged 5 commits into
moira/skills-api-referencesfrom
moira/skills-hydration

Conversation

@moirahuang
Copy link
Copy Markdown
Contributor

@moirahuang moirahuang commented May 29, 2026

Description

PR 3/5 of the remote-aware skills stack.

Hydrate project skills from remote working directories and classify provider locations structurally, without temporarily coercing remote locations into local paths for shared logic.

Plan: https://staging.warp.dev/drive/notebook/EAngN0Hb9BqY5WiPMTXFV5
Agent run: https://staging.warp.dev/conversation/88702634-8ffe-46a4-b868-1efae92630eb

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • cargo fmt --manifest-path Cargo.toml -p warp_util -p ai -p warp

  • cargo test -p ai skill_provider --lib

  • cargo test -p warp parse_remote_skill_file_contexts --lib

  • Full workspace clippy was started on the cumulative stack tip but not completed before submission.

  • I have manually tested my changes locally with ./script/run

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-Authored-By: Oz oz-agent@warp.dev

@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 29, 2026

@moirahuang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor Author

moirahuang commented May 29, 2026

@moirahuang moirahuang changed the title Hydrate remote project skills [3/5] Hydrate remote project skills May 29, 2026
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR extends project skill watching to hydrate remote skill files through the remote server read-file context API, parse them as project skills, and handle remote skill deletion paths. It also adds unit coverage for remote parsing, provider classification, read request limits, and remote deletion events.

Concerns

  • The remote refresh branch currently moves repo_id and then tries to clone it again, which will fail to compile.
  • This is user-facing behavior because remote project skills become available to agents, but the PR description has no testing notes or screenshots/recording demonstrating the remote hydration path end to end. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.

Verdict

Found: 1 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

local_skill_files,
ctx,
);
if let RepositoryIdentifier::Remote(remote_repo) = repo_id {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 [CRITICAL] This match moves repo_id into remote_repo, then the body calls repo_id.clone() and later uses repo_id again, so this branch will not compile. Borrow the enum in the pattern instead.

Suggested change
if let RepositoryIdentifier::Remote(remote_repo) = repo_id {
if let RepositoryIdentifier::Remote(remote_repo) = &repo_id {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@moirahuang moirahuang requested a review from kevinyang372 May 29, 2026 00:44
Comment thread crates/ai/src/skills/skill_provider.rs Outdated
Comment thread app/src/ai/skills/file_watchers/skill_watcher.rs Outdated
@moirahuang moirahuang merged commit 8953eb7 into moira/skills-api-references May 29, 2026
4 of 5 checks passed
@moirahuang moirahuang deleted the moira/skills-hydration branch May 29, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants