Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovery parsed every non-skipped module under the root. Only
dist,build, and dotfiles were skipped, so leftover bundles in folders such asdist-preview/were parsed on every build. 8 MB of stale bundles took a build from 1.0 s to 4.4 s.Ignores.create(new,src/node/internal/Ignores.ts) reads.gitignorefiles from the repository root down, or from the scanned directory outside a repository, including negations. The Vite plugin's discovery andzyzz.config.*search skip ignored paths and each environment'sbuild.outDir, unless the output directory contains a source directory (such asoutDir: '..'). The portable adapters' scan applies the same rules and skips esbuild'soutdir.dist-*/foldersvite buildNo change for a clean project. Output CSS is identical.
Validation: new
skips ignored files and build output in discoveryscenario (fails without the change),tsc, and the same suites (211 tests) pass.Merging this after #527 leaves one conflict in
configResolvedofsrc/vite/index.ts: keep both the transform-filter block and theoutDirsblock.