PEP 825: add a non-normative section on multiple sources - Michal#62
PEP 825: add a non-normative section on multiple sources - Michal#62mgorny wants to merge 3 commits into
Conversation
Signed-off-by: Michał Górny <mgorny@quansight.com>
Documentation build overview
740 files changed ·
|
DEKHTIARJonathan
changed the title
Signed-off-by: Michał Górny <mgorny@quansight.com>
|
I've integrated some of Jonathan's ideas from #63. One thing I've left were PEP 766 references; while it's a draft, I think it's fine to mention it in non-normative section as a prior art. |
|
|
||
| It is entirely valid for tools not to support this behavior, either by | ||
| not providing support for using multiple sources at all, or by rejecting | ||
| to proceed if more than one of the sources includes variant wheels. |
There was a problem hiding this comment.
The easiest for tools is to always have an index order which avoids inter-index comparisons.
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks for writing this! A couple of small textual suggestions only.
| not providing support for using multiple sources at all, or by rejecting | ||
| to proceed if more than one of the sources includes variant wheels. | ||
|
|
||
| When processing variant wheels from different sources, it is recommended |
There was a problem hiding this comment.
"sources" could be mildly confusing perhaps (could also be read as different authors/orgs, or source code), so I suggest:
| When processing variant wheels from different sources, it is recommended | |
| When processing variant wheels from different indexes, it is recommended |
Should be clearer, unless there's also an issue with non-index sources (i.e., a local build?)
There was a problem hiding this comment.
Yeah, my understanding was that we want to cover non-index sources as well.
Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>
4 participants
No description provided.