Skip to content

Simon/ci/stage jvm android before publish wpb 22853#1875

Merged
typfel merged 12 commits intomainfrom
simon/ci/stage-jvm-android-before-publish-WPB-22853
Mar 6, 2026
Merged

Simon/ci/stage jvm android before publish wpb 22853#1875
typfel merged 12 commits intomainfrom
simon/ci/stage-jvm-android-before-publish-WPB-22853

Conversation

@SimonThormeyer
Copy link
Member

@SimonThormeyer SimonThormeyer commented Feb 19, 2026

What's new in this PR

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer force-pushed the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch 30 times, most recently from 2eb56e1 to be9a42d Compare February 20, 2026 13:08
@SimonThormeyer SimonThormeyer force-pushed the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch 3 times, most recently from db676c7 to 9e429e0 Compare February 20, 2026 14:14
@typfel typfel force-pushed the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch 6 times, most recently from 121ba32 to 0f454fa Compare March 3, 2026 14:41
@typfel typfel marked this pull request as ready for review March 4, 2026 09:07
@typfel typfel requested a review from a team March 4, 2026 09:07
coriolinus
coriolinus approved these changes Mar 5, 2026
View reviewed changes
Copy link
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a large-ish caveat here, in that I am flying blind when it comes to Gradle and the JVM ecosystem. I don't know what I'm talking about, there.

That said, aside from the one nit, I see nothing to complain about here. Looks plausible!

.github/workflows/prepare-publish.yml
@@ -0,0 +1,65 @@
name: prepare publish
Copy link
Contributor

@coriolinus coriolinus Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name could be significantly more descriptive here. Maybe "prepare publish jvm" or "... sonatype" or something?

Copy link
Member Author

@SimonThormeyer SimonThormeyer Mar 5, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is supposed to contain prepare publish jobs for any platform, not just jvm. E.g., the verify-tag job is platform-independent. Potentially in the future, we might require additional prepare jobs for platforms other than jvm, which is why keeping the workflow name generic here makes sense imo.

The "prepare publish jvm" naming you suggest is pretty similar to what you get if you compose the workflow name "prepare publish" and the respective job name, "jvm".

Note, there's also an "android" job.

@coriolinus coriolinus mentioned this pull request Mar 5, 2026
Open
3 tasks
@typfel typfel force-pushed the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch from 0f454fa to 7ae24a6 Compare March 6, 2026 09:28
SimonThormeyer and others added 12 commits March 6, 2026 10:53
@SimonThormeyer @typfel
build(gradle): use gradle-nexus publish plugin
4ed65a4 
And configure acccording to
https://github.com/gradle-nexus/publish-plugin?tab=readme-ov-file#publishing-to-maven-central-via-sonatype-central
@SimonThormeyer @typfel
build(gradle/jvm): use gradle-nexus publish plugin
f00e2ba
@SimonThormeyer @typfel
ci(jvm): fix: more specific jvm bindings target path
1772c41
@SimonThormeyer @typfel
ci(jvm): stage before releasing
93d47a1
@SimonThormeyer @typfel
build(gradle/android): use gradle-nexus publish plugin
dd13f4e
@SimonThormeyer @typfel
ci(android): stage before releasing
535f8d2
@SimonThormeyer @typfel
ci: move prepare-publish into its own workflow
ad62ebe 
GHA doesn't allow calling other workflows as job steps, they need to be
their own job. So we're factoring out the the entire prepare-publish job
into its own workflow  so that prepare-jvm and prepare-android can be
their own job.
@SimonThormeyer @typfel
refactor: naming inconsistencies in gradle properties
b2b2af2
@typfel
build(gradle/kmp): use gradle-nexus publish plugin
84dfa13
@typfel
chore: explictly set package group
609b2dd
@typfel
fix(build): update versions script doesn't support all legal characte…
2e7759e 
…rs for gradle & swift versions
@typfel
ci: stop uploading android and jvm artifacts to the release during pu…
6f07736 
…blishing

Now that we use the staging area at sonatype there's no point in uploading them anymore.
@typfel typfel force-pushed the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch from 7ae24a6 to 6f07736 Compare March 6, 2026 09:55
@typfel typfel merged commit 6f07736 into main Mar 6, 2026
50 checks passed
@typfel typfel deleted the simon/ci/stage-jvm-android-before-publish-WPB-22853 branch March 6, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonThormeyer @coriolinus @typfel