Skip to content

fix(getBrandId): parameterize text prompt #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinkace wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(getBrandId): parameterize text prompt #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3656437
fix: parameterize getBrandId() text prompt
kevinkace Apr 28, 2026
76c90fc
nullish and optional
kevinkace Apr 29, 2026
e4c12fa
Merge branch 'master' into kevinkace/fix-list-prompt
kevinkace May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/zcli-themes/src/commands/themes/import.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export default class Import extends Command {
let { flags: { brandId }, argv: [themeDirectory] } = await this.parse(Import)
const themePath = path.resolve(themeDirectory)

brandId = brandId || await getBrandId()
brandId = brandId || await getBrandId('What brand should the theme be imported to?')

const job = await createThemeImportJob(brandId)
const { file, removePackage } = await createThemePackage(themePath)
Expand Down
2 changes: 1 addition & 1 deletion packages/zcli-themes/src/commands/themes/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class List extends Command {
async run () {
let { flags: { brandId } } = await this.parse(List)

brandId = brandId || await getBrandId()
brandId = brandId || await getBrandId('What brand should the themes be listed for?')

try {
CliUx.ux.action.start('Listing themes')
Expand Down
4 changes: 2 additions & 2 deletions packages/zcli-themes/src/lib/getBrandId.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Brand } from '../types'
import { request } from '@zendesk/zcli-core'
import * as inquirer from 'inquirer'

export default async function getBrandId (): Promise<string> {
export default async function getBrandId (message?: string): Promise<string> {
try {
const { data: { brands } } = await request.requestAPI('/api/v2/brands.json', {
validateStatus: (status: number) => status === 200
Expand All @@ -16,7 +16,7 @@ export default async function getBrandId (): Promise<string> {
const { brandId } = await inquirer.prompt({
type: 'list',
name: 'brandId',
message: 'What brand should the theme be imported to?',
message: message ?? 'Choose a brand',
choices: brands.map((brand: Brand) => ({
Comment thread
kevinkace marked this conversation as resolved.
name: brand.name,
value: brand.id.toString()
Expand Down
Loading